Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow NamedTuple as select expression #767

Closed
wants to merge 15 commits into from
Closed

Conversation

scotttrinh
Copy link
Collaborator

@scotttrinh scotttrinh commented Nov 7, 2023

We noticed that actually using full-text search from the query builder wasn't working due to a few things:

  • We were not properly returning the anytype in the new anyobject case
  • We did not have an overload or code path that expected a named tuple in the "expression" position of a select expression.

TODO:

  • Add more overloads for handling no-shape selects
  • Check regular tuples

@scotttrinh scotttrinh closed this Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant